Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: use settings to determine whether or not to fetch ads #646

Merged
merged 7 commits into from
Nov 28, 2023

Conversation

hcaula
Copy link
Contributor

@hcaula hcaula commented Nov 22, 2023

What problem is this solving?

In order to stop requiring changes to the store theme for fetching ads, we now use the setting fetchSponsoredProductsOnSearch.

How to test it?

Use the workspace below and log window.__RUNTIME__.settings['vtex.store'] in your console. You should find the setting fetchSponsoredProductsOnSearch.

Workspace

Screenshots or example usage:

image

Related to / Depends on

Depends on:

@hcaula hcaula self-assigned this Nov 22, 2023
@hcaula hcaula requested a review from a team as a code owner November 22, 2023 20:17
@hcaula hcaula requested review from gvc, lucasfp13 and lariciamota and removed request for a team November 22, 2023 20:17
Copy link
Contributor

vtex-io-ci-cd bot commented Nov 22, 2023

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

react/components/SearchQuery.js Outdated Show resolved Hide resolved
@hcaula hcaula merged commit 7cab124 into master Nov 28, 2023
3 of 5 checks passed
@hcaula hcaula deleted the feat/fetch-ads-if-in-settings branch November 28, 2023 16:59
Copy link
Contributor

vtex-io-ci-cd bot commented Nov 28, 2023

Your PR has been merged! App is being published. 🚀
Version 3.127.1 → 3.128.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants